Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify in README.md that we switched to gymnasium. #824

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

ernestum
Copy link
Collaborator

For new users it is unclear whether imitation is based on gym or gymnasium (e.g. users got confused here #815).
This PR adds a quick note about this to the README.md.

@ernestum
Copy link
Collaborator Author

@AdamGleave would you add this repository to the gymnasium github topic? This would additionally increase discoverability as it shows up on the front page of the repo right under the documentation link.

@ernestum ernestum requested review from Rocamonde and removed request for dan-pandori November 30, 2023 13:57
@ernestum
Copy link
Collaborator Author

Note: the failing type check will be fixed by #822.

Copy link
Member

@AdamGleave AdamGleave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Show resolved Hide resolved
@AdamGleave
Copy link
Member

@AdamGleave would you add this repository to the gymnasium github topic? This would additionally increase discoverability as it shows up on the front page of the repo right under the documentation link.

Good idea, done!

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (928d576) 95.66% compared to head (c696cb0) 95.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #824   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files         102      102           
  Lines        9655     9655           
=======================================
  Hits         9236     9236           
  Misses        419      419           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernestum ernestum merged commit 3649188 into master Dec 5, 2023
15 checks passed
@ernestum ernestum deleted the advertise_gymnasium branch December 5, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants